Skip to content

Fix #5006: Enforce asInstanceOf to be a Select node #6874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2019
Merged

Fix #5006: Enforce asInstanceOf to be a Select node #6874

merged 1 commit into from
Jul 18, 2019

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki marked this pull request as ready for review July 17, 2019 15:32
@nicolasstucki nicolasstucki requested a review from smarter July 17, 2019 15:32
@smarter
Copy link
Member

smarter commented Jul 17, 2019

This fix seems like a bit of hack to me, why would asInstanceOf be special ? Why not isInstanceOf ? etc. dotty-staging@6cc105c is more principled (use desugarIdent before matching on Select)

@nicolasstucki
Copy link
Contributor Author

I reused the fix in dotty-staging/dotty-1@6cc105c

smarter
smarter requested changes Jul 18, 2019
View reviewed changes
@nicolasstucki nicolasstucki merged commit ff2a65f into scala:master Jul 18, 2019
@nicolasstucki nicolasstucki deleted the fix-#5006 branch July 18, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees

@smarter smarter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @smarter